Skip to content

feat: optimistic concurrency guard on release_milestone (#1319) - #1386

Open
Simultech369 wants to merge 1 commit into
Talenttrust:mainfrom
Simultech369:fix-1319-concurrency
Open

Simultech369 wants to merge 1 commit into
Talenttrust:mainfrom
Simultech369:fix-1319-concurrency

Conversation

@Simultech369

Copy link
Copy Markdown
Contributor

Fixes #1319

Summary of Changes

  • Optimistic Concurrency Guard: Added expected_version to the release_milestone entrypoint.
  • State Machine Integration: Added check_version_for_concurrency before release and store_milestone_transition to correctly bump the monotonic version and write the audit trail on success.
  • Test Suite Adjustments: Safely propagated the updated entrypoint signature expected_version: &0 across 60+ testing files ensuring parity with the new API shape.

(Note: Several integration tests on main were discovered to be failing locally with Error(Contract, #52) related to missing settlement tokens prior to this branch. These were skipped during validation as they appear to be upstream regressions on main.)

@Simultech369

Copy link
Copy Markdown
Contributor Author

Hi @mikewheeleer, friendly check-in on PR #1386 (optimistic concurrency guard on release_milestone for #1319). All Rust CI build and test checks are green and ready for your review whenever you have a moment. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

optimistic-concurrency guard on the release_milestone entrypoint

1 participant