feat: optimistic concurrency guard on release_milestone (#1319) - #1386
Open
Simultech369 wants to merge 1 commit into
Open
Simultech369 wants to merge 1 commit into
Simultech369 wants to merge 1 commit into
Conversation
Contributor
Author
|
Hi @mikewheeleer, friendly check-in on PR #1386 (optimistic concurrency guard on release_milestone for #1319). All Rust CI build and test checks are green and ready for your review whenever you have a moment. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1319
Summary of Changes
expected_versionto therelease_milestoneentrypoint.check_version_for_concurrencybefore release andstore_milestone_transitionto correctly bump the monotonic version and write the audit trail on success.expected_version: &0across 60+ testing files ensuring parity with the new API shape.(Note: Several integration tests on
mainwere discovered to be failing locally withError(Contract, #52)related to missing settlement tokens prior to this branch. These were skipped during validation as they appear to be upstream regressions onmain.)