Skip to content

chore: add .agentsroom to .gitignore #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jherr wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore: add .agentsroom to .gitignore #460

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f942667
chore: update project agent configuration
jherr Apr 16, 2026
0466ecd
chore: update project agent configuration
jherr Apr 16, 2026
b76472a
chore: update project agent configuration
jherr Apr 16, 2026
e69026e
chore: add .agentsroom to .gitignore
jherr Apr 16, 2026
7df615b
ci: apply automated fixes
autofix-ci[bot] Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .agentsroom/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# AgentsRoom: personal files (not committed to git)
*-personal.json
agents-local.json
sessions/
Comment on lines +1 to +4
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Critical: This file won't be tracked due to root .gitignore conflict.

The root .gitignore adds .agentsroom on line 74, which ignores the entire .agentsroom/ directory. This means .agentsroom/.gitignore itself won't be tracked by git, making these ignore patterns ineffective.

If the intent is to track the .agentsroom/ directory structure while excluding only personal/local data, the root .gitignore should NOT ignore the entire directory. Instead, rely solely on this .agentsroom/.gitignore to exclude personal files.

🔧 Proposed fix: Remove `.agentsroom` from root `.gitignore`

Remove line 74 from the root .gitignore file:

-.agentsroom

This allows .agentsroom/.gitignore to control what is excluded within that directory.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.agentsroom/.gitignore around lines 1 - 4, The root .gitignore currently
ignores the entire .agentsroom directory which prevents .agentsroom/.gitignore
from being tracked; remove the `.agentsroom` entry from the root .gitignore so
that the repository will track the .agentsroom directory and defer exclusions to
.agentsroom/.gitignore (which contains patterns like `*-personal.json`,
`agents-local.json`, and `sessions/`); after removing that entry, verify
`.agentsroom/.gitignore` is committed so its local-personal exclusions take
effect.

10 changes: 10 additions & 0 deletions .agentsroom/agents.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
[
{
"role": "fullstack",
"model": "opus",
"customName": "Full-Stack Developer",
"isPersonal": false,
"id": "agent-1776361243376-3sekdc",
"claudeSessionId": "96773a93-be2a-45a9-a732-ceb224d3d0e5"
}
]
Comment on lines +1 to +10
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Critical/Major: File won't be tracked, and contains session-specific data that shouldn't be committed.

Two issues:

  1. Critical: This file won't be tracked because the root .gitignore ignores the entire .agentsroom/ directory (see comment on .gitignore line 74).

  2. Major: Even if this file were tracked, it contains session-specific identifiers (claudeSessionId, id) that appear to be personal/local data and should not be committed to a shared repository. These should either be:

    • Excluded via .agentsroom/.gitignore patterns (e.g., this could be agents-local.json)
    • Removed/templated if this is meant to be a committed configuration file

The PR description states the goal is to "prevent agent session files from being committed," which suggests these session identifiers should not be in version control.

🔧 Recommended approach

If the intent is to provide a template configuration:

  1. Remove session-specific values and provide a template:
 [
   {
     "role": "fullstack",
     "model": "opus",
     "customName": "Full-Stack Developer",
     "isPersonal": false,
-    "id": "agent-1776361243376-3sekdc",
-    "claudeSessionId": "96773a93-be2a-45a9-a732-ceb224d3d0e5"
   }
 ]

  1. Rename to agents-example.json or document that users should copy this to agents-local.json (which is gitignored per .agentsroom/.gitignore).

  2. Optionally, add a trailing newline for consistency.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
[
{
"role": "fullstack",
"model": "opus",
"customName": "Full-Stack Developer",
"isPersonal": false,
"id": "agent-1776361243376-3sekdc",
"claudeSessionId": "96773a93-be2a-45a9-a732-ceb224d3d0e5"
}
]
[
{
"role": "fullstack",
"model": "opus",
"customName": "Full-Stack Developer",
"isPersonal": false
}
]
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.agentsroom/agents.json around lines 1 - 10, This file contains
session-specific identifiers (claudeSessionId and id) and is inside a directory
already ignored by the root .gitignore; remove or template those values and make
the file a safe, trackable example: strip or replace claudeSessionId and id with
placeholders (e.g., "<CLAUDE_SESSION_ID>" / "<AGENT_ID>") and rename the file to
a committed template like agents-example.json (or document that users copy it to
agents-local.json which is listed in .agentsroom/.gitignore); ensure keys such
as role, model, customName remain intact and add a trailing newline.

4 changes: 4 additions & 0 deletions .agentsroom/prompts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"folders": [],
"prompts": []
}
Comment on lines +1 to +4
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Note: File won't be tracked due to root .gitignore conflict.

This file won't be tracked because the root .gitignore ignores the entire .agentsroom/ directory (see comment on .gitignore line 74).

Additionally, consider adding a trailing newline at the end of the file to follow common JSON file conventions.

📝 Optional: Add trailing newline 
 {
   "folders": [],
   "prompts": []
 }
+
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
{
"folders": [],
"prompts": []
}
{
"folders": [],
"prompts": []
}
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.agentsroom/prompts.json around lines 1 - 4, The .agentsroom/prompts.json
file is currently ignored by the root .gitignore because the pattern
".agentsroom/" excludes the whole directory; either remove or refine that ignore
pattern in .gitignore (or add an explicit negation like
"!.agentsroom/prompts.json") so this file can be tracked, and also add a
trailing newline to the end of prompts.json to follow JSON file conventions.

1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,4 +71,5 @@ docs/superpowers
# Only .claude.settings.json should be committed
.claude/settings.local.json
.claude/worktrees/*
.agentsroom
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Critical: Ignoring entire .agentsroom/ directory conflicts with tracking configuration files.

Adding .agentsroom to the root .gitignore prevents ALL files in that directory from being tracked, including the .agentsroom/agents.json, .agentsroom/prompts.json, and .agentsroom/.gitignore files that this PR attempts to commit.

Based on the .agentsroom/.gitignore patterns (*-personal.json, agents-local.json, sessions/), it appears the intent is to:

  1. Track base configuration files (e.g., agents.json, prompts.json)
  2. Exclude only personal/local data via .agentsroom/.gitignore

This line should be removed to allow the .agentsroom/ directory to be tracked, with .agentsroom/.gitignore controlling what gets excluded.

🔧 Proposed fix: Remove this line 
-.agentsroom

Rely on .agentsroom/.gitignore to exclude personal/local files instead.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
.agentsroom
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.gitignore at line 74, Remove the top-level ".agentsroom" ignore entry from
the root .gitignore so the repository can track files like
.agentsroom/agents.json and .agentsroom/prompts.json; rely on the
.agentsroom/.gitignore (which already lists patterns like "*-personal.json",
"agents-local.json", and "sessions/") to exclude only personal/local files
instead of ignoring the entire directory.

solo.yml
Loading