Add retroactive OTel execution lifecycle tracing#252
Open
morgan-wowk wants to merge 1 commit into
Open
Conversation
Collaborator
Author
This was referenced May 22, 2026
morgan-wowk
force-pushed
the
execution-tracing-core
branch
from
ebcd9a2 to
e9fe6e0
Compare
Emits a root 'execution' span and one 'execution.status' child span per status history entry when an ExecutionNode reaches a terminal state. All span timestamps are derived from the existing status history so durations reflect actual time spent, not when this code ran. - New module: cloud_pipelines_backend/instrumentation/execution_tracing.py - Hook: metrics._handle_before_commit calls try_emit_execution_trace - Orchestrator: otel.setup_providers() so the exporter is active - Tests: InMemorySpanExporter-backed suite in tests/instrumentation/
morgan-wowk
force-pushed
the
execution-tracing-core
branch
from
e9fe6e0 to
059c47b
Compare
Ark-kun
reviewed
May 26, 2026
| def _ns(*, dt: datetime.datetime) -> int: | ||
| """Return *dt* as nanoseconds since the Unix epoch (required by OTel SDK). | ||
|
|
||
| Uses integer arithmetic on timedelta components to avoid float64 precision |
Contributor
There was a problem hiding this comment.
I'm not sure timedelta.total_seconds induces loss of precision... Can you elaborate?
But not a blocker.
Ark-kun
reviewed
May 26, 2026
|
|
||
| root.end(end_time=_ns(dt=last_time)) | ||
| except Exception: | ||
| _logger.warning( |
Contributor
There was a problem hiding this comment.
It's OK to do _logger.exception
Ark-kun
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Emits a root
executionspan and oneexecution.statuschild span perstatus history entry when an
ExecutionNodereaches a terminal state. Allspan timestamps are derived from the existing status history so durations
reflect actual time spent, not when this code ran.
cloud_pipelines_backend/instrumentation/execution_tracing.pymetrics._handle_before_commitcallstry_emit_execution_traceotel.setup_providers()so the exporter is activeInMemorySpanExporter-backed suite intests/instrumentation/Screenshots