Skip to content
Open
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

@yceballost yceballost Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buttonLink chevron is quite difficult to solve in this moment. @aweell and I consider to go forward with this PR although this case is not solved properly, but we are solving accessibility issues and this problem is just aesthetic
image

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get why other screenshots of tables change since the tags now can be higher, but this one?

@yceballost yceballost Sep 11, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the old one you can see ellipsis. This happens becauuse the column is very narrow

Try reducing the width in this story and you can see the same as the screenshot
https://mistica-6vauh9y0v-flows-projects-65bb050e.vercel.app/?path=/story/components-table--default

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 5 additions & 2 deletions src/__stories__/chip-story.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ type Args = {
active: boolean;
badge: string;
href: string;
label: string;
};

type Props = {
Expand Down Expand Up @@ -57,6 +58,7 @@ export const Default: StoryComponent<Args> = ({
badge,
active: chipActive,
href: hrefProp,
label,
}) => {
const props = {
Icon: icon ? IconLightningFilled : undefined,
Expand All @@ -71,10 +73,10 @@ export const Default: StoryComponent<Args> = ({
<ChipBackgroundContainer dataAttributes={{testid: 'chip'}} inverse={inverse}>
{closable ? (
<Chip onClose={() => window.alert('closed')} {...rest}>
Chip
{label}
</Chip>
) : (
<Chip {...props}>Chip</Chip>
<Chip {...props}>{label}</Chip>
)}
</ChipBackgroundContainer>
);
Expand Down Expand Up @@ -177,6 +179,7 @@ export const NavigableChip: StoryComponent<{
};

const defaultArgs = {
label: 'Chip',
inverse: false,
active: false,
badge: '0',
Expand Down
11 changes: 2 additions & 9 deletions src/button.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,18 +29,11 @@ import type {ExclusifyUnion} from './utils/utility-types';
const ButtonTextRenderer = ({element, small}: {element: React.ReactNode; small?: boolean}) => {
const {textPresets} = useTheme();
return small ? (
<Text
size={14}
lineHeight={20}
weight={textPresets.button.weight}
truncate={1}
color="inherit"
as="div"
>
<Text size={14} lineHeight={20} weight={textPresets.button.weight} color="inherit" as="div">
{element}
</Text>
) : (
<Text3 weight={textPresets.button.weight} truncate={1} color="inherit" as="div">
<Text3 weight={textPresets.button.weight} color="inherit" as="div">
{element}
</Text3>
);
Expand Down
2 changes: 1 addition & 1 deletion src/chip.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ const Chip = (props: ChipProps): JSX.Element => {
</div>
)}
<Box paddingRight={badge ? 8 : 0 || onClose ? 4 : 0}>
<Text2 id={id} weight={textPresets.indicator.weight} truncate={1} color="currentColor">
<Text2 id={id} weight={textPresets.indicator.weight} color="currentColor">
{children}
</Text2>
</Box>
Expand Down
2 changes: 1 addition & 1 deletion src/skins/blau.tsx

@yceballost yceballost Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These token changes are to avoid these cases when the text size increase

image

Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ export const getBlauSkin: GetKnownSkin = () => {
button: '4px',
checkbox: '2px',
container: '8px',
indicator: '999px',
indicator: '24px',
input: '8px',
legacyDisplay: '16px',
popup: '8px',
Expand Down
2 changes: 1 addition & 1 deletion src/skins/esimflag.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ export const getEsimflagSkin: GetKnownSkin = () => {
borderRadii: {
avatar: '50%',
bar: '999px',
button: '999px',
button: '32px',
checkbox: '4px',
container: '20px',
indicator: '8px',
Expand Down
2 changes: 1 addition & 1 deletion src/skins/movistar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ export const getMovistarSkin: GetKnownSkin = () => {
button: '4px',
checkbox: '2px',
container: '8px',
indicator: '999px',
indicator: '24px',
input: '8px',
legacyDisplay: '16px',
popup: '8px',
Expand Down
4 changes: 2 additions & 2 deletions src/skins/o2-new.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -366,10 +366,10 @@ export const getO2NewSkin: GetKnownSkin = () => {
borderRadii: {
avatar: '50%',
bar: '999px',
button: '999px',
button: '32px',
checkbox: '2px',
container: '16px',
indicator: '999px',
indicator: '24px',
input: '12px',
legacyDisplay: '16px',
popup: '8px',
Expand Down
2 changes: 1 addition & 1 deletion src/skins/o2.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ export const getO2Skin: GetKnownSkin = () => {
button: '4px',
checkbox: '2px',
container: '8px',
indicator: '999px',
indicator: '24px',
input: '8px',
legacyDisplay: '16px',
popup: '8px',
Expand Down
4 changes: 2 additions & 2 deletions src/skins/telefonica.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -367,10 +367,10 @@ export const getTelefonicaSkin: GetKnownSkin = () => {
borderRadii: {
avatar: '50%',
bar: '0px',
button: '999px',
button: '32px',
checkbox: '0px',
container: '0px',
indicator: '999px',
indicator: '24px',
input: '0px',
legacyDisplay: '0px',
popup: '0px',
Expand Down
4 changes: 2 additions & 2 deletions src/skins/tu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -360,10 +360,10 @@ export const getTuSkin: GetKnownSkin = () => {
borderRadii: {
avatar: '50%',
bar: '999px',
button: '999px',
button: '32px',
checkbox: '2px',
container: '16px',
indicator: '999px',
indicator: '24px',
input: '12px',
legacyDisplay: '16px',
popup: '8px',
Expand Down
4 changes: 2 additions & 2 deletions src/skins/vivo-new.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -356,10 +356,10 @@ export const getVivoNewSkin: GetKnownSkin = () => {
borderRadii: {
avatar: '50%',
bar: '999px',
button: '999px',
button: '32px',
checkbox: '2px',
container: '16px',
indicator: '999px',
indicator: '24px',
input: '12px',
legacyDisplay: '16px',
popup: '8px',
Expand Down
2 changes: 1 addition & 1 deletion src/skins/vivo.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ export const getVivoSkin: GetKnownSkin = () => {
button: '4px',
checkbox: '2px',
container: '8px',
indicator: '999px',
indicator: '24px',
input: '8px',
legacyDisplay: '16px',
popup: '8px',
Expand Down
8 changes: 1 addition & 7 deletions src/tag.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -117,13 +117,7 @@ const Tag = ({
</Box>
)}
<ThemeVariant isInverse={false}>
<Text
color={textColor}
size={14}
lineHeight={20}
weight={textPresets.indicator.weight}
truncate
>
<Text color={textColor} size={14} lineHeight={20} weight={textPresets.indicator.weight}>
{children}
</Text>
{badgeValue !== 0 && (
Expand Down
Loading