Skip to content

fix(knowledge): bubble embedding model resolution failure for retry #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdrkrg wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix(knowledge): bubble embedding model resolution failure for retry #2620

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9d48593
test(knowledge): reproduce embedding model failure stuck in processing
mdrkrg Aug 9, 2026
2582d6c
fix(knowledge): bubble embedding model resolution failure for retry
mdrkrg Aug 9, 2026
7d22bce
refactor(knowledge): extract knowledge failure helpers
mdrkrg Aug 9, 2026
5a074c1
fix(knowledge): don't clobber cancelled/deleting status on failure
mdrkrg Aug 9, 2026
b5e680d
test(knowledge): cover failure paths outside ProcessDocument
mdrkrg Aug 9, 2026
62cf1dc
test(knowledge): regress cancelled-parent manual reparse failure
mdrkrg Aug 12, 2026
6ae1246
fix(knowledge): use detached context for goroutine failure write
mdrkrg Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions internal/application/service/knowledge_create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1180,10 +1180,10 @@ func sanitizeManualDownloadFilename(title string) string {

func (s *knowledgeService) triggerManualProcessing(ctx context.Context,
kb *types.KnowledgeBase, knowledge *types.Knowledge, content string, doSync bool,
) {
) error {
clean := strings.TrimSpace(content)
if clean == "" {
return
return nil
}

// Resolve embedded data:base64 images and remote http(s) images → storage, replace URLs.
Expand Down Expand Up @@ -1265,10 +1265,17 @@ func (s *knowledgeService) triggerManualProcessing(ctx context.Context,
}

if doSync {
s.processChunks(ctx, kb, knowledge, parsed, opts)
return
return s.processChunks(ctx, kb, knowledge, parsed, opts)
}

newCtx := logger.CloneContext(ctx)
go s.processChunks(newCtx, kb, knowledge, parsed, opts)
go func() {
if err := s.processChunks(newCtx, kb, knowledge, parsed, opts); err != nil {
logger.GetLogger(newCtx).WithField("error", err).
Errorf("triggerManualProcessing process chunks failed")
// No error channel out of the goroutine: fail the row in place.
s.markKnowledgeFailed(ctx, knowledge, err.Error())
}
}()
return nil
}
Loading