Skip to content

fix(ci): resolve go vet redeclaration in session continue-stream tests - #2635

Draft
nullptr-error with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-github-actions-job
Draft

fix(ci): resolve go vet redeclaration in session continue-stream tests#2635
nullptr-error with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-github-actions-job

Conversation

Copilot AI commented Aug 10, 2026

Copy link
Copy Markdown

Description

The Format, vet, test, and build workflow failed because go vet detected a duplicate test type declaration in internal/handler/session. This PR removes the collision with a minimal, test-only rename.

  • Root cause

    • stubSessionService in continue_stream_resource_urls_test.go conflicted within the session test package during vet analysis.
  • Change

    • Renamed the local test stub type and receiver to a file-specific name and updated its construction site.
type stubContinueStreamSessionService struct {
	interfaces.SessionService
}

func (s *stubContinueStreamSessionService) GetSession(_ context.Context, id string) (*types.Session, error) {
	return &types.Session{ID: id, TenantID: 1}, nil
}

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 💥 Breaking change
  • 📚 Documentation update
  • 🎨 Refactor
  • ⚡ Performance improvement
  • 🧪 Test
  • 🔧 Configuration / Build / CI

Related Issue

Handled by automatic issue linking.

Testing

Confirmed the prior vet failure condition is removed and package-level continue-stream tests still pass.

Checklist

  • git diff --check origin/main...HEAD passes
  • Changed source files are formatted
  • Targeted tests for the changed packages/components pass
  • Diff-scoped lint passes where applicable (for Go: golangci-lint run --new-from-rev=origin/main ./...)
  • Full-repository checks were run, or any unrelated/environment-dependent failures are documented above
  • Self-reviewed the code
  • Added/updated tests covering the change
  • Updated related documentation (README, docs/, Swagger annotations, etc.)
  • Breaking changes are clearly called out in the description above

Screenshots / Recordings

N/A (no user-visible UI change)

Co-authored-by: nullptr-error <104547331+nullptr-error@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job Format, vet, test, and build fix(ci): resolve go vet redeclaration in session continue-stream tests Aug 10, 2026
Copilot AI requested a review from nullptr-error August 10, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants