fix(im): handle unresolved Feishu resource images - #2761
Open
Jonesxq wants to merge 1 commit into
Open
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Feishu interactive cards reject unresolved
resource://Markdown images as invalid image keys. The adapter's image matcher only handled HTTP(S), so unresolved resource handles passed through unchanged and could make the entire card update fail.This change:
resource://image targets inresolveMarkdownImages;image_keypath unchanged.Type of Change
Related Issue
Fixes #2726
Testing
All commands pass; golangci-lint reports
0 issues.The full repository suite was not run because the change is isolated to the Feishu adapter; the complete
internal/im/...package tree was tested.Checklist
git diff --check origin/main...HEADpassesScreenshots / Recordings
Not applicable; this is an IM adapter behavior fix.