fix: bound wiki reduce input growth - #2779
Open
Hughhhhcoder wants to merge 2 commits into
Open
Conversation
Author
|
The latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bound the aggregate trim-eligible inputs sent to WikiPageModify with an explicit WikiConfig byte budget. This prevents hub-page reduce prompts from growing without limit while preserving deletion instructions and keeping stable source/page context where possible.
Type of Change
Related Issue
Fixes #2718
Testing
go test ./internal/application/service -run TestTrimWikiReduceInputsBoundsConfiguredContext -count=1go test ./internal/application/service -run "TestTrimWikiReduceInputsBoundsConfiguredContext|TestGenerateWithTemplateSetsMaxTokens" -count=1go test ./internal/application/service -count=1go test ./internal/types ./internal/application/service -count=1git diff --checkgo test ./...was also run; it reached the repository test execution but stopped because the host filesystem ran out of space (no space left on device), with no assertion failure reported. The focused and changed-package tests pass.Checklist
git diff --check origin/main...HEADpasses