perf(history): reduce redundant reads#1944
Merged
Merged
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
hasMessages(sessionId)query usingSELECT 1 ... LIMIT 1and use it where session orchestration only needs a boolean.docs/architecture/history-read-hot-path/spec.md.Why
The send path was materializing full history for a boolean check. Structured history assembly also repeated single-message queries after successful bulk reads returned empty buckets. The earlier isolated baseline measured the smallest fixture moving from 8 full reads / 120 SQL statements to 7 / 105 after the existence query, then to 7 / 35 after removing the empty-bucket N+1 fallback. This PR ports only those two low-risk fixes onto the latest
dev; it does not include the benchmark platform or broader audit work.Impact
Validation
pnpm run typecheck:nodepnpm run format:checkpnpm run i18npnpm run lintgit diff --check origin/dev...HEADFull suite, E2E, and full build were intentionally not run; the change is covered by focused contract tests and real SQLite verification.
Summary by CodeRabbit
Performance Improvements
Tests
Documentation