fix(acp): refresh direct runtime on config

[zerob13]

Summary

• close enabled direct ACP runtimes before the global ACP provider is disabled
• refresh changed or removed registry-backed runtimes after registry initialization and manual refresh
• add regression coverage for both lifecycle paths

Root cause

The compatibility provider no longer owns the shared ACP runtime. Global disable and registry refresh only updated provider/catalog state, leaving hydrated direct runtimes alive or stale.

Validation

• pnpm run typecheck
• pnpm run test:main (341 files, 3706 tests passed)
• pnpm exec vitest run test/main/presenter/configPresenter/fontSizeSettings.test.ts
• pnpm run format
• pnpm run i18n
• pnpm run lint

Follow-up to #1952.

Summary by CodeRabbit

• Bug Fixes
  • Improved ACP registry synchronization by refreshing only agents whose configurations changed.
  • Ensured affected ACP agents are refreshed before ACP is disabled.
  • Improved initialization and registry refresh behavior to keep agent state up to date.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 11c63156-c3b7-4902-9e0c-7d2f6fd41423

📥 Commits

Reviewing files that changed from the base of the PR and between 6d6f396 and 7227452.

📒 Files selected for processing (2)

• src/main/presenter/configPresenter/index.ts
• test/main/presenter/configPresenter/fontSizeSettings.test.ts

---

📝 Walkthrough

Walkthrough

Changes

ACP registry refresh flow

Layer / File(s)	Summary
Registry agent change detection src/main/presenter/configPresenter/index.ts	Adds deep comparison of previous and updated ACP registry agents to identify changed IDs.
Registry lifecycle integration src/main/presenter/configPresenter/index.ts, test/main/presenter/configPresenter/fontSizeSettings.test.ts	Applies selective provider refreshes during initialization and registry refresh, refreshes enabled direct agents before ACP disable cleanup, and tests both behaviors.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant ConfigPresenter
  participant acpRegistryService
  participant Repository
  participant ACPProviderAgents
  ConfigPresenter->>acpRegistryService: Refresh registry
  acpRegistryService-->>ConfigPresenter: Return updated agents
  ConfigPresenter->>Repository: Sync registry state
  ConfigPresenter->>ACPProviderAgents: Refresh changed agent IDs

Loading

Possibly related PRs

• ThinkInAIXYZ/deepchat#1579: Also updates ACP registry change detection and incremental agent refresh behavior.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/acp-runtime-refresh-fix

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}