Repository navigation
Geometry viewer: tetra face-centre probe arrow ends on the face, not the cube corner - #60
Merged
Merged
Conversation
…the cube corner The blue face-centre arrow used the same D/2 step along (1,1,1) as the vertex arrow, so its tip landed at (D,D,D), three times past the Q2Q3Q4 centroid at (2D/3,2D/3,2D/3) and outside the tetrahedron, while the red (vertex) and green (edge midpoint) arrows ended on their features. Step is now D/6 so the tip is the centroid. Reported by petrus on the live viewer. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by @Petrus on the live viewer: "the blue part extends out of the 4q".
Cause: the blue face-centre probe arrow used the same
D/2step along (1,1,1) as the vertex arrow, so its tip landed at (D,D,D), the cube's far corner, three times past the Q2Q3Q4 centroid at (2D/3,2D/3,2D/3) and outside the tetrahedron. The red (vertex) and green (edge midpoint) arrows already ended exactly on their features.Fix: step
D/6along (1,1,1), tip = centroid. Directions unchanged, so the in-wedge statement in the comment still holds. Applied to the live viewer too.🤖 Generated with Claude Code