Remove serialization non C41 constructors from stats#4706
Merged
Conversation
With this change in, PR #4685 and others to follow should: a) remove Subarray::set_stats and respective call from serialization/query.cc b) where Subarray is constructed in serialization/query.cc, change constructor call with the following code snippet: auto &stats_data = stats_from_capnp(reader.getStats()); Subarray subarray(array, layout, query_stats, stats_data, dummy_logger, true); c) The constructor calls parent_stats->create_child(prefix, stats_data); d) When all migrations are done, make Stats::populate_with_data private
|
This pull request has been linked to Shortcut Story #40316: Remove serialization non C.41 constructors from stats.. |
KiterLuc
reviewed
Feb 9, 2024
Contributor
KiterLuc
left a comment
KiterLuc
left a comment
There was a problem hiding this comment.
As discussed offline, let's try to make the stats() accessors of all class return a const Stats& object. Let's also validate that the stats we get from REST are identical before and after this change.
Contributor
Author
|
Manually tested this in a local REST server and stats are identical before and after the change. |
KiterLuc
approved these changes
Feb 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change in, PR #4685 and others to follow should:
a) remove
Subarray::set_statsand respective call fromserialization/query.ccb) whereSubarray is constructed inserialization/query.cc`, change constructor call with the following code snippet:c) The constructor calls parent_stats->create_child(prefix, stats_data); d) When all migrations are done, make
Stats::populate_with_data privateTYPE: NO_HISTORY
DESC: Remove serialization non C41 constructors from stats