Update crop_range to clamp to domain range.#4781
Merged
Conversation
|
This pull request has been linked to Shortcut Story #42320: Update crop range to clamp on domain. |
KiterLuc
approved these changes
Mar 2, 2024
davisp
pushed a commit
to davisp/TileDB
that referenced
this pull request
Mar 3, 2024
While working on TileDB-Inc#4685 we found it was possible for a cropped range to fall outside of the given domain range. This updates crop_range to call `std::clamp` instead of min/max to ensure the resulting cropped range is within the domain. --- TYPE: BUG DESC: Update crop_range to clamp to domain range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #4685 we found it was possible for a cropped range to fall outside of the given domain range. This updates crop_range to call
std::clampinstead of min/max to ensure the resulting cropped range is within the domain.TYPE: BUG
DESC: Update crop_range to clamp to domain range.