Conversation
rroelke
commented
Jun 29, 2025
| set(bridge_h_src "${bridge_generated_dir}/src/${bridge}.h") | ||
| set(bridge_cc_src "${bridge_generated_dir}/src/${bridge}.cc") | ||
|
|
||
| string(REPLACE "-" "_" bridge_sanitize_relpath ${bridge_sanitize_relpath}) |
Contributor
Author
There was a problem hiding this comment.
This is not directly related to the PR description but was causing problems in some of my build environments.
I was building in $HOME/tiledb/TileDB-4 and the previous code was replacing that with $HOME/tiledb/TileDB_4 which was messing up include paths.
This correction only makes this substitution for the path components after tiledb/oxidize.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is split off of #5566 in order to keep that pull request more focused.
Differences in copy and move semantics between Rust and C++ mean that they are generally not very good at passing values across the boundary - most of the time it is necessary to pass references instead.
#5566 intends to call
Attribute::get_enumeration_namefrom Rust. Prior to these changes, that function returnsstd::optional<std::string>, which cannot be passed across the boundary (neitherstd::optionalnorstd::stringcan be). We can either pass a pointer to a string, or pass a string contained within a smart pointer.To avoid the additional memory allocations required for both copying the
std::stringand placing it in aunique_ptr, we choose the former.However,
std::optionaldoes not naturally support references, so we cannot dostd::optional<std::string&>. Instead we change the return type tostd::optional<std::reference_wrapper<std::string>>.In addition to enabling passing the result of this function to Rust without allocating additional memory, this also avoids making additional copies of the string. This is not likely to matter from a performance perspective, but is still nice!
TYPE: NO_HISTORY
DESC: Rust binding for
Attribute::get_enumeration_name