Skip to content

Centralize ambient colors#1507

Open
wipheg wants to merge 1 commit into
Together-Java:developfrom
wipheg:issue-1506-ambient-colors
Open

Centralize ambient colors#1507
wipheg wants to merge 1 commit into
Together-Java:developfrom
wipheg:issue-1506-ambient-colors

Conversation

@wipheg

@wipheg wipheg commented Jun 21, 2026

Copy link
Copy Markdown

Closes #1506

Summary

  • Add AmbientColors as a central place for Discord embed accent colors
  • Replace scattered feature-specific color constants with named shared colors
  • Reuse matching colors across related features, such as role management and moderation embeds

Testing

  • ./gradlew.bat spotlessCheck test

@wipheg wipheg requested a review from a team as a code owner June 21, 2026 18:40
@CLAassistant

CLAassistant commented Jun 21, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@Zabuzard Zabuzard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@wipheg wipheg force-pushed the issue-1506-ambient-colors branch from 8427940 to d1c138b Compare June 22, 2026 07:25
@Zabuzard

Copy link
Copy Markdown
Member

Heyho, if possible, after CR has started please refrain from doing force-pushes. Messes up the reviewer flow in GitHub, cheers.

@Zabuzard Zabuzard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff :)

@Zabuzard

Copy link
Copy Markdown
Member

You need to sign the CLA still 👍

@Zachdehooge Zachdehooge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wipheg

wipheg commented Jun 23, 2026

Copy link
Copy Markdown
Author

@Zabuzard , Sorry for the delay, I didn’t notice the CLA was still pending. I’ve signed it now.

Thanks again for the review!

@Zabuzard

Copy link
Copy Markdown
Member

Awesome, everything set then. Just one more approval (or ill merge it in a week or so) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Centralize Ambient-Color management

5 participants