Apply transform of first LOD to MeshAsset Instances#726
Draft
aidandavey wants to merge 6 commits intoTokisanGames:mainfrom
Draft
Apply transform of first LOD to MeshAsset Instances#726aidandavey wants to merge 6 commits intoTokisanGames:mainfrom
aidandavey wants to merge 6 commits intoTokisanGames:mainfrom
Conversation
035737d to
7f57fa6
Compare
Owner
Contributor
Author
|
Thinking on this, baking the LOD transform into the instance data might not be what we want to do. It doesn't allow for modification afterwards, and causes an issue with my instance collision PR since I need the shape positions, not the LOD. In fact baking the variation transforms might already be an issue there. I'm thinking the instancer data could hold the instance_origin, and a variation transform. The LOD transform, and CollisionShape transform, will remain in the MA data and can be applied in update_mmis and/or update_instance_collision, in the proper order region->instance->correction->variation This also sets us up to support an instance transform brush, so you can paint alternative variation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



As discussed on previous PR #724, applying transforms from the first LOD mesh in the MeshAsset file while painting instances.