Redesign Asset dock for Godot 4.6#925
Draft
TokisanGames wants to merge 7 commits intomainfrom
Draft
Conversation
f331b77 to
e1969fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #921
Fixes #931
godotengine/godot#106503 (presumably) broke the asset dock by improperly deprecating the old functions and breaking them, and redesigning new functions.
This PR make a 4.6 compatible asset dock and switches between the new in 4.6+ and old in <=4.5.
Pre 4.5 the editor docks were quite clunky and I wrote a lot of code to handle it's quirks. In 4.6 the system has been redesigned and things that didn't work now do. We no longer need our own dock selector as the built in one finally works properly.
Pending:
Cherry-pick for 1.0.2