feat(imageloader): dedicated thread pool for blocking IO#461
Merged
Conversation
This change is more involved than it sounds: by being loaded in a separate threadpool, image data IO and decoding is now better parallelized. A few redundant copies are now also avoided. However, this change requires adapting pretty much all format-specific loaders (as well as the EXIF metadata loader) in order to avoid said unnecessary copies. The net result is faster bulk image loading (IO no longer blocks CPU-intensive work and vice versa) at the cost of a bit more RAM (all encoded images go into memory up front).
Tom94
force-pushed
the
dedicated-io-threadpool
branch
from
e3fd037 to
1c17f9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is more involved than it sounds: by being loaded in a separate threadpool, image data IO and decoding is now better parallelized. A few redundant copies are now also avoided. However, this change requires adapting pretty much all format-specific loaders (as well as the EXIF metadata loader) in order to avoid said unnecessary copies.
The net result is faster bulk image loading (IO no longer blocks CPU-intensive work and vice versa) at the cost of a bit more RAM (all encoded images go into memory up front).