Fixing electron preselection

[sscruz]

No description provided.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.29%. Comparing base (3471b74) to head (6b7815c).
⚠️ Report is 198 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
- Coverage   25.43%   25.29%   -0.15%     
==========================================
  Files          35       31       -4     
  Lines        5185     4977     -208     
==========================================
- Hits         1319     1259      -60     
+ Misses       3866     3718     -148     

Flag	Coverage Δ
unittests	25.29% <ø> (-0.15%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bryates]

Thanks @sscruz, looks good to me! @Andrew42 do you have any comments?

[anpicci]

@bryates , since we are already using this fix in master:
https://github.com/TopEFT/topeft/blob/master/topeft/modules/object_selection.py#L189
shall we close this PR?

[bryates]

@bryates , since we are already using this fix in master: https://github.com/TopEFT/topeft/blob/master/topeft/modules/object_selection.py#L189 shall we close this PR?

I don't think we are. The code you linked shows the old etaSC call. @sscruz can you confirm this is needed.