Added player-to-player tempflight payments.

[Triumvir-Civ]

Summary

Adds an optional command allowing players to transfer their available tempflight time directly to another player.

Usage

/tfly pay <player> <time>

Time accepts raw seconds or the existing s, m, h, and d suffixes.

Configuration

The feature is disabled by default:

options:
  allow_tempflight_payments: false

Players require the following permission, which defaults to true:

townyflight.command.tfly.pay

Behaviour

• Supports online and offline Towny residents.
• Prevents payments to yourself.
• Rejects invalid amounts and insufficient balances.
• Protects against recipient balance overflow.
• Updates both players’ persistent tempflight metadata immediately.
• Updates active in-memory balances for online players.
• Notifies online recipients when they receive time.
• Uses the existing auto-enable flight behaviour for eligible online recipients.
• Adds configurable messages, help output and tab completion.
• Does not require recipient confirmation.

Testing

• git diff --check passes.
• mvn clean package completes successfully with Java 21.
• Builds jar.
• Tested functionality in-game on our pre-production server.

[LlmDl]

This stuff feels really messy, instead of using a recipient player throughout the early parts of this method I'd use the resident instead.

String recipientName = args[0];
Resident recipientRes = TownyAPI.getInstance().getResident(recipientName);
if (recipientRes == null) {
Message.of("Player " + recipientName + " not found. Could not transfer tempflight.").to(sender);
return;
}

UUID recipientUUID = recipientRes.getUUID();
if (player.getUniqueID().equals(recipientUUID)) {
Message.of(Message.getLangString("tempFlightPaymentSelf")).to(sender);
return;
}

[Triumvir-Civ]

Really valid critique - I've made that change to use resident throughout, but I've kept in the backup UUID check for the not found message, just as a failsafe.

[LlmDl]

This can be replaced with if (recipientResident.isOnline()) {

and then use resident.getPlayer() inside the if block.

[Triumvir-Civ]

Updated!

[LlmDl]

Not sure why you're using Players here again, you only need to use the resident.isOnline().

[Triumvir-Civ]

Yeah noted, updated to use the residents' online state rather than the Bukkit lookup.