Sqlite#140
Open
KillerOfPie wants to merge 31 commits into
Open
Conversation
and refactor some methods from JsonLinkageConfiguration into interface LinkageConfiguration (as default methods)
- Updated plugin versions in POM.xml - Fix for non DATA_ERROR debug output
- Moved inventoryGUI to a local directory instead of it's own to prevent potential conflicts - Fix for add Error during shop creation when adding users.
- RemoveSide commands now default to the only item if no index was specified and the shop only has one item on the side - Fix for members showing up as managers in the edit menu - Fix for managers not showing in edit menu
- Change ShopItemStack.itemstack to serialize using ItemStack#serialize rather than base64, This increases readability and decreases file size
KillerOfPie
commented
Jul 5, 2022
KillerOfPie
left a comment
KillerOfPie
left a comment
Collaborator
Author
There was a problem hiding this comment.
looks good - pre testing
The latter is because SQLite's ResultSets only support FORWARD_ONLY_CURSORs, such that moving up and down the rows is not possible. Checking the size of the ResultSet is now done more subtly, but also in a more crude way.
- Add SQLITE option to data-storage-type pre-comment - POM Version updates - POM Improvements - Added `Clean` and `skipDocs` profiles for maven builds - Moved `original` and JavaDocs output to `target/output-Files` sub folders - Updated JavaDoc exclusions - Excluded `META-INF/maven` files from builds
Collaborator
Author
|
When it comes time to merge, keep |
…robustiveness of the Database transactions. This will reduce the risk of data loss at the cost of having shop operations fail early.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
There are several guidelines you should follow in order for your Pull Request to be merged.
Replace
[ ]with[x]to cross the checkbox.Changes
This PR adds a new kind of storage type which relies on a single SQLite database file, created, read and updated on disk.