Skip to content

fix(security): [security improvement] Add state limit to builder to prevent DoS #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tugamer89 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(security): [security improvement] Add state limit to builder to prevent DoS #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/main/java/org/eu/autogex/core/AbstractAutomatonBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
public abstract class AbstractAutomatonBuilder<
B extends AbstractAutomatonBuilder<B, A>, A extends Automaton> {

/** Maximum allowed states in an Automaton to prevent memory/state explosion (DoS). */
protected static final int MAX_STATES = 10000;

protected final Map<String, State> states = new HashMap<>();
protected final Set<State> finalStates = new HashSet<>();
protected State initialState;
Expand All @@ -39,6 +42,10 @@ protected AbstractAutomatonBuilder() {
* @return The current builder instance.
*/
public B addState(String name, boolean isFinal) {
if (!states.containsKey(name) && states.size() >= MAX_STATES) {
throw new IllegalStateException(
"Automaton state limit exceeded (Security: DoS prevention).");
}
State state = new State(name, isFinal);
states.put(name, state);
if (isFinal) {
Expand Down