Skip to content

fix(ui): improve screen reader feedback for code snippet copy action#167

Open
Tugamer89 wants to merge 1 commit into
mainfrom
jules-1302221385556577449-e7e6e9e9
Open

fix(ui): improve screen reader feedback for code snippet copy action#167
Tugamer89 wants to merge 1 commit into
mainfrom
jules-1302221385556577449-e7e6e9e9

Conversation

@Tugamer89

Copy link
Copy Markdown
Owner

What: Replaced the dynamic inline aria-live state change on the code block copy button with a dedicated, visually hidden aria-live region (sr-announcer) that reliably announces "Code copied to clipboard".

Why: Modifying the aria-label or contents of an element that already has focus and an inline aria-live attribute is famously unreliable across screen readers. A dedicated, off-screen live region is the standard pattern for programmatic UI announcements.

Before/After: Visually identical. A screenshot of the "Copied!" state was provided via Playwright execution.

Accessibility: Greatly improves screen reader reliability by properly announcing asynchronous state changes using the standard aria-live="polite" and aria-atomic="true" techniques.


PR created automatically by Jules for task 1302221385556577449 started by @Tugamer89

Replaced inline aria-live attributes with a dedicated, visually hidden sr-announcer div, allowing reliable screen reader announcements when the user copies a code snippet to their clipboard.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant