Skip to content

Lily/Video -- Fix video playback opening popups & add documentation - #2597

Open
SharkPool-SP wants to merge 4 commits into
masterfrom
a-lot-of-human-fixes-and-improvements
Open

Lily/Video -- Fix video playback opening popups & add documentation#2597
SharkPool-SP wants to merge 4 commits into
masterfrom
a-lot-of-human-fixes-and-improvements

Conversation

@SharkPool-SP

@SharkPool-SP SharkPool-SP commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Changes:

  • Fixed video playback opening popups on mobile
  • Added docs

Closes:
#1084

@github-actions github-actions Bot added the pr: change existing extension Pull requests that change an existing extension label Jul 20, 2026
@GarboMuffin

Copy link
Copy Markdown
Member

please submit them separately the mega pull request was not intended to be repeated

@GarboMuffin

Copy link
Copy Markdown
Member

And make a new issue. The one you linked here is distinct from the one you saw

@SharkPool-SP

Copy link
Copy Markdown
Collaborator Author

please submit them separately the mega pull request was not intended to be repeated

uhm okay. I want to add docs to close another issue too

@GarboMuffin

Copy link
Copy Markdown
Member

Or just don't make an issue, but anyway theres no reason this fix would be believes to be related

@GarboMuffin

Copy link
Copy Markdown
Member

If its the same extension you can get away with merging them easkly

@SharkPool-SP SharkPool-SP changed the title A lot of human fixes and improvements Lily/Video -- Fix video playback opening popups & add documentation Jul 20, 2026
@SharkPool-SP
SharkPool-SP marked this pull request as ready for review July 20, 2026 05:27
@SharkPool-SP

Copy link
Copy Markdown
Collaborator Author

If its the same extension you can get away with merging them easkly

okay done

@SharkPool-SP

Copy link
Copy Markdown
Collaborator Author

Also before I forget, before vs after:
After:

trim.C69DC14B-BF86-471F-8F79-9E7FE81B2F71.MOV

Before:

trim.581CFF8C-B0E4-40DB-B2DE-AC3E403530E0.MOV

@SharkPool-SP
SharkPool-SP requested review from a team and Brackets-Coder July 20, 2026 17:17

@GarboMuffin GarboMuffin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: change existing extension Pull requests that change an existing extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants