CST1229/zip.js -- Use correct MIME type when reading file Data.URIs - #2600
Open
SharkPool-SP wants to merge 4 commits into
Open
CST1229/zip.js -- Use correct MIME type when reading file Data.URIs#2600SharkPool-SP wants to merge 4 commits into
SharkPool-SP wants to merge 4 commits into
Conversation
github-actions
Bot
added
the
pr: change existing extension
Collaborator
Author
|
!format |
GarboMuffin
reviewed
Jul 25, 2026
Collaborator
Author
|
!format |
|
I'd say this is a good change. Does it understand ALL file types? Or no. (I'm hoping it understands code files like js, lua, rb, py, etc etc) |
Collaborator
Author
whichever the database supports, which includes js and lua... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves:
#1682
Before:
After:
Not exactly a behavior-changing commit. It doesnt break compatibility since extensions such as Skins would reject the old output whereas now it will accept it.