-
Notifications
You must be signed in to change notification settings - Fork 213
feat(bot-oo): add include/exclude proposal lists to OOv2 settler #4952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
md0x
wants to merge
4
commits into
master
Choose a base branch
from
pablo/oo-settle-include-exclude
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
85fc0e0
feat(bot-oo): add include/exclude proposal lists to OOv2 settler
md0x a397008
fix(bot-oo): accept explicit empty settle include/exclude lists
md0x 980c45d
fix(bot-oo): throw when settle lists are set for non-OOv2 oracle types
md0x 422e568
fix(bot-oo): accept empty settle exclude list for non-OOv2 oracle types
md0x File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
ORACLE_TYPEisOptimisticOracleorSkinnyOptimisticOracleand a shared deployment template rendersSETTLE_EXCLUDE_LIST=[],parseProposalIdListreturns an emptySet, making this condition truthy and causing startup to throw. That contradicts the documented behavior that an empty exclude list behaves like unset, so non-OOv2 bots can be prevented from starting even though the list would skip nothing.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 422e568. An empty exclude list now behaves the same as unset for any oracle type, so templated
SETTLE_EXCLUDE_LIST=[]no longer blocks non-OOv2 startup. An empty include list still throws for non-OOv2, since "settle nothing" cannot be honored there. Added a test and updated the README.