Repository navigation
fix: defaults to ip unless fqdn - #2370
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Deterministic regression coverage is needed because the existing assertions depend on the runner’s DNS configuration.
1 open issue
What changed in this PR
Addresses #2369 by using the display IP when the resolved hostname lacks a dot, avoiding single-label hostnames that remote clients cannot resolve.
Changes:
- Adds an IP fallback for single-label hostnames.
- Updates the display test helper’s expected value.
| File | Description |
|---|---|
| t/vm/23_display.t | Aligns expected hostnames with the IP fallback. |
| lib/Ravada/Domain.pm | Rejects single-label resolved display hostnames. |
Review effort: Balanced
Comment on lines
+181
to
+183
| return $hostname if $hostname =~ /\./; | ||
|
|
||
| return $ip; |
| return $hostname; | ||
| return $hostname if $hostname =~ /\./; | ||
|
|
||
| die "Error: I cant get a fqdn of $ip"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2369