Skip to content

Misleading names across scheduling/intake/notes code #299

Description

@TusharW4ni

Part of #285 (Group D — robustness).

Problem

Several files/routes are named for something other than what they do, which actively misleads anyone navigating the code (and slowed this analysis).

Evidence

  • pages/patient/viewContactForms.vue (+ server/api/request/processing.get.ts) lists Request rows, not ContactForms.
  • pages/userService/assignNeuroSpecialist.vue assigns therapists to referrals (stage 4), not evaluators. Actual evaluator assignment lives in pages/userService/viewAppointmentRequests.vue.
  • components/therapy/ReportModal.vue (alias TherapyReportModal, modal key progressReport) is the TherapyNote editor; the real Report model is elsewhere (see [Epic] Connect the end-to-end patient journey (request → intake → evaluator → referral → session → notes) #285 D13).
  • components/userService/AssignModal.vue in appointment mode renders a submittedAt field that only exists on referrals (always "—").

Impact

P3 (maintainability). High confusion cost; easy to wire the wrong endpoint.

Proposed approach

  • Rename to match behavior (routes, files, component aliases, i18n keys) or add clear header comments where a rename is risky.
  • Remove the submittedAt field from AssignModal's appointment mode.
  • Do this alongside the functional issues that touch these files to minimize churn.

Acceptance criteria

  • Names reflect behavior (or documented why not).
  • The appointment-mode submittedAt artifact is removed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3: lowPolish, nice-to-havetech-debtCode cleanup, refactoring, dependency maintenance

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions