Bootcamp: WILLIAM - #328
Closed
itxwilliam wants to merge 6 commits into
Closed
itxwilliam wants to merge 6 commits into
itxwilliam wants to merge 6 commits into
Conversation
EemanAleem
requested changes
Sep 17, 2026
EemanAleem
left a comment
EemanAleem
left a comment
Contributor
There was a problem hiding this comment.
Heyu, great job! Just some small changes, some room for optimizing your prescaler for greter accuracy.
| /* USER CODE END WHILE */ | ||
| HAL_GPIO_WritePin(GPIOB, GPIO_PIN_8, GPIO_PIN_RESET); | ||
|
|
||
| HAL_SPI_TransmitReceive(&hspi1, tx_buffer, rx_buffer, BUFFER_SIZE, TIMEOUT); |
Contributor
There was a problem hiding this comment.
Function call is correct, but it'd be useful to know whether it was successful or not! The function's return value being exposed to the developer would be helpful in debugging as good practice!
| TIM1.Channel-PWM\ Generation1\ CH1=TIM_CHANNEL_1 | ||
| TIM1.IPParameters=Channel-PWM Generation1 CH1,Prescaler,Period | ||
| TIM1.Period=56470 | ||
| TIM1.Prescaler=16 |
Contributor
There was a problem hiding this comment.
You can get your prescaler to be lower for greater accuracy!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.