Repository navigation
fix(generator): include payment_authentication in common schemas - #81
Closed
yuhuayang-google wants to merge 1 commit into
Closed
yuhuayang-google wants to merge 1 commit into
yuhuayang-google wants to merge 1 commit into
Conversation
Fixes Universal-Commerce-Protocol#64 (payment_authentication exclusion) generate_models.sh previously omitted common/payment_authentication.json, leaving dev.ucp.common.payment.authentication schemas ungenerated. This adds payment_actions and dev.ucp.shopping.checkout definitions under schemas/common/payment_authentication.json to QUICKTYPE_ARGS.
damaz91
added
status:needs-triage
Contributor
|
Thanks @yuhuayang-google , closing this one as superseded by #82 which fixes the root cause |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses #64 (undocumented
payment_authenticationexclusion).generate_models.shpreviously omittedcommon/payment_authentication.json, leavingdev.ucp.common.payment.authenticationdefinitions ungenerated.This change adds
payment_actionsanddev.ucp.shopping.checkoutdefinitions under$SPEC_DIR/schemas/common/payment_authentication.jsontoQUICKTYPE_ARGSwhen the schema file is present, matching the structure used forpayment_ap2_mandate.json.