feat: add catalog discount previews - #715
Draft
ShuoRen-TT wants to merge 2 commits into
Draft
Conversation
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dev.ucp.shopping.discountto Catalog Lookupdiscounts.availableonly onget_productresponsesavailable_discountmodel introduced by feat: add discoverable available discounts to discount extension #609Proposal and dependency
Draft implementation for #707.
This PR is intentionally stacked on #609 and includes its current commit so the Catalog composition can reference
available_discount. It should not merge until:mainso the final diff contains only the Catalog-specific changesScope
get_productdiscounts.codesordiscounts.appliedin Catalogappliedorremaining_amountin Catalog preview entriesValidation
ucp-schema 1.4.1 lint source/pre-commit run --files docs/specification/discount.md source/schemas/shopping/discount.jsonpython scripts/validate_examples.py --schema-base source/schemas/(294 passed)python scripts/test_validate_examples.py(50 passed)get_productand batchlookupbash scripts/build_local.sh --draft-onlyRefs #707
Depends on #609