Skip to content

feat: add catalog discount previews - #715

Draft
ShuoRen-TT wants to merge 2 commits into
Universal-Commerce-Protocol:mainfrom
ShuoRen-TT:agent/catalog-discount-previews
Draft

feat: add catalog discount previews#715
ShuoRen-TT wants to merge 2 commits into
Universal-Commerce-Protocol:mainfrom
ShuoRen-TT:agent/catalog-discount-previews

Conversation

@ShuoRen-TT

Copy link
Copy Markdown

Summary

Proposal and dependency

Draft implementation for #707.

This PR is intentionally stacked on #609 and includes its current commit so the Catalog composition can reference available_discount. It should not merge until:

Scope

  • no changes to the core Catalog schema
  • no changes to Catalog Search or batch Lookup
  • no discount submission from get_product
  • no discounts.codes or discounts.applied in Catalog
  • no applied or remaining_amount in Catalog preview entries
  • no private discount code exposure

Validation

  • ucp-schema 1.4.1 lint source/
  • pre-commit run --files docs/specification/discount.md source/schemas/shopping/discount.json
  • python scripts/validate_examples.py --schema-base source/schemas/ (294 passed)
  • python scripts/test_validate_examples.py (50 passed)
  • strict composed-schema checks for Catalog get_product and batch lookup
  • bash scripts/build_local.sh --draft-only

Refs #707
Depends on #609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants