fix(payment-actions): disambiguate action.ready result - #730
Open
pranshu-10 wants to merge 2 commits into
Open
Conversation
pranshu-10
force-pushed
the
fix/action-ready-result-schema
branch
from
August 14, 2026 18:17
98db4e3 to
6480a78
Compare
pranshu-10
marked this pull request as ready for review
August 14, 2026 18:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Constrains the successful
action.readyresult to an empty object.Problem
The
action.readyresult usesoneOffor:error_response.The success branch previously accepted any JSON object. A valid error response therefore matched both branches, causing
oneOfvalidation to fail.Fix
Add
maxProperties: 0to the success branch so that only{}is accepted as a successful acknowledgement.Verification
{}remains valid.error_responseobjects now match only the error branch.Category (Required)
Please select one or more categories that apply to this change.
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
N/A — this PR fixes a directly identified schema validation bug.
Checklist
!for breaking changes).Screenshots / Logs (if applicable)
Used the above python script to validate following test cases for before and after the fix
1. Valid empty success
Expected:
Before fix: PASS
After fix: PASS
2. Valid error response
Expected:
Before fix: FAIL incorrectly
After fix: PASS
3. Invalid non-empty acknowledgement
Expected:
Before fix: PASS incorrectly
After fix: FAIL