Skip to content

docs: update fulfillment and total amounts in discount spec example - #754

Open
kev-mao wants to merge 1 commit into
Universal-Commerce-Protocol:mainfrom
kev-mao:patch-1
Open

docs: update fulfillment and total amounts in discount spec example#754
kev-mao wants to merge 1 commit into
Universal-Commerce-Protocol:mainfrom
kev-mao:patch-1

Conversation

@kev-mao

@kev-mao kev-mao commented Aug 20, 2026

Copy link
Copy Markdown

The mixed-discounts response example in the discount extension shows a 599 free-shipping discount as both discount: -599 and fulfillment: 0, with total: 2601. This double-counts the discount. This change keeps the shipping discount in the discount line (per Impact on Line Items and Totals) and fixes the example to show the gross fulfillment: 599 and total: 3200, satisfying the totals summation invariant.

Description

Category (Required)

Please select one or more categories that apply to this change.

  • Core Protocol: Changes to the base communication layer, global context, or breaking refactors. (Requires Technical Council approval)
  • Governance/Contributing: Updates to GOVERNANCE.md, CONTRIBUTING.md, or CODEOWNERS. (Requires Governance Council approval)
  • Capability: New schemas (Discovery, Cart, etc.) or extensions. (Requires Maintainer approval)
  • Documentation: Updates to README, or documentations regarding schema or capabilities. (Requires Maintainer approval)
  • Infrastructure: CI/CD, Linters, or build scripts. (Requires DevOps Maintainer approval)
  • Maintenance: Version bumps, lockfile updates, or minor bug fixes. (Requires DevOps Maintainer approval)
  • SDK: Language-specific SDK updates and releases. (Requires DevOps Maintainer approval)
  • Samples / Conformance: Maintaining samples and the conformance suite. (Requires Maintainer approval)
  • UCP Schema: Changes to the ucp-schema tool (resolver, linter, validator). (Requires Maintainer approval)
  • Community Health (.github): Updates to templates, workflows, or org-level configs. (Requires DevOps Maintainer approval)

Related Issues

Checklist

  • I have followed the Contributing Guide (including Conventional Commits title requirements and ! for breaking changes).
  • I have updated the documentation (if applicable).
  • My changes pass all local linting and formatting checks.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • (For Core/Capability) I have included/updated the relevant JSON schemas.
  • I have regenerated Python Pydantic models by running generate_models.sh under python_sdk.

Screenshots / Logs (if applicable)

The mixed-discounts example in the discount extension shows a 599 free-shipping discount as both `discount: -599` and `fulfillment: 0`, with `total: 2601`. This double-counts the discount. Fixed by changing to `fulfillment: 599` and `total: 3200` as expected.
@google-cla

google-cla Bot commented Aug 20, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kev-mao kev-mao changed the title Update fulfillment and total amounts in discount spec example docs: update fulfillment and total amounts in discount spec example Aug 20, 2026
@damaz91 damaz91 added status:needs-triage Signal that the PR is ready for human triage documentation Improvements or additions to documentation status:under-review and removed status:needs-triage Signal that the PR is ready for human triage labels Aug 20, 2026
@damaz91
damaz91 requested review from alexpark20 and westeezy August 21, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:payments documentation Improvements or additions to documentation status:under-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants