docs: update fulfillment and total amounts in discount spec example - #754
Open
kev-mao wants to merge 1 commit into
Open
docs: update fulfillment and total amounts in discount spec example#754kev-mao wants to merge 1 commit into
kev-mao wants to merge 1 commit into
Conversation
The mixed-discounts example in the discount extension shows a 599 free-shipping discount as both `discount: -599` and `fulfillment: 0`, with `total: 2601`. This double-counts the discount. Fixed by changing to `fulfillment: 599` and `total: 3200` as expected.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mixed-discounts response example in the discount extension shows a 599 free-shipping discount as both
discount: -599andfulfillment: 0, withtotal: 2601. This double-counts the discount. This change keeps the shipping discount in the discount line (per Impact on Line Items and Totals) and fixes the example to show the grossfulfillment: 599andtotal: 3200, satisfying the totals summation invariant.Description
Category (Required)
Please select one or more categories that apply to this change.
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
Checklist
!for breaking changes).Screenshots / Logs (if applicable)