Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change improves client address detection for gRPC connections when frp-panel is deployed behind a reverse proxy.
Currently,
ClientAddr()relies only onpeer.FromContext(), which returns the direct gRPC peer address. When a reverse proxy such as Nginx, EdgeOne, or another CDN/proxy is used, the displayed client address becomes the proxy's address instead of the original client IP.This change updates
ClientAddr()to:X-Real-IPfrom incoming gRPC metadata.X-Forwarded-For.peer.Addrbehavior when proxy headers are unavailable.This keeps direct gRPC deployments fully compatible while allowing deployments behind trusted reverse proxies to display the actual client IP.
Example proxy configuration:
Security note:
X-Real-IPandX-Forwarded-Forshould only be trusted when requests come through a trusted reverse proxy. Deployments should restrict direct access to the gRPC origin or configure the proxy trust boundary appropriately.