Let Options open at any max instances that can be set - #819
Merged
Conversation
maxInstancesNumericUpDown was left at NumericUpDown's default Maximum of 100 while MaxInstance takes any ushort, so DiffEngine_MaxInstances=500 made the OptionsForm constructor throw ArgumentOutOfRangeException on the line that shows the current value - and Options is where that value would have been lowered again, so the tray was stuck with it until the environment variable was edited by hand. The spinner's range is now the range the setting has.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maxInstancesNumericUpDown was left at NumericUpDown's default Maximum of 100 while
MaxInstance takes any ushort, so DiffEngine_MaxInstances=500 made the OptionsForm
constructor throw ArgumentOutOfRangeException on the line that shows the current
value - and Options is where that value would have been lowered again, so the tray
was stuck with it until the environment variable was edited by hand.
The spinner's range is now the range the setting has.