Encode the issue title like the body - #821
Open
SimonCropp wants to merge 1 commit into
Open
Conversation
The URL the tray opens after an error put the raw message in title= while encoding body=. The message carries a file path, so a '#' in one - a directory named C# will do it - started a fragment: the body went, and the title ended at the hash. An '&' started a parameter GitHub does not have, truncating the title there. Both halves are built in one place now, and the title goes through UrlEncode. The body still arrives already encoded from its callers, which is why it is appended rather than encoded again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The URL the tray opens after an error put the raw message in title= while encoding
body=. The message carries a file path, so a '#' in one - a directory named C# will
do it - started a fragment: the body went, and the title ended at the hash. An '&'
started a parameter GitHub does not have, truncating the title there.
Both halves are built in one place now, and the title goes through UrlEncode. The
body still arrives already encoded from its callers, which is why it is appended
rather than encoded again.