Re-register the hot keys as one thing or not at all - #823
Merged
Conversation
Saving Options cleared and re-registered all three hot keys and only then looked at whether any of them had failed. A collision on the second returned "Binding already registered" with the first already live on its new combination, the second unbound, and settings.json - written after this - still holding the old ones. So the dialog said the save had failed while the keys said otherwise, until the tray was restarted. A failed attempt now puts back the bindings that were live before it. That the restore itself succeeded is not reported: they are the bindings the tray already had, and there is nothing to be done at the dialog about one of them having been taken since.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving Options cleared and re-registered all three hot keys and only then looked at
whether any of them had failed. A collision on the second returned "Binding already
registered" with the first already live on its new combination, the second unbound,
and settings.json - written after this - still holding the old ones. So the dialog
said the save had failed while the keys said otherwise, until the tray was
restarted.
A failed attempt now puts back the bindings that were live before it. That the
restore itself succeeded is not reported: they are the bindings the tray already
had, and there is nothing to be done at the dialog about one of them having been
taken since.