Pass over a bundled viewer path that is not on this machine - #824
Merged
Conversation
On .NET Framework the path to the bundled viewer is carried as assembly metadata, and every assembly built against the package carries one - prebuilt dependencies included, where it is the package path of the machine that built them. The scan took the first non-empty value it met and stopped, so a Verify.dll from NuGet arriving before the test assembly handed back a directory that does not exist here, the RID probe missed, and inline snapshots fell back to staging with a viewer sitting in the package all along. A value naming a directory that is not here is now passed over and the scan continues, and the entry assembly - the one the targets stamped for this build - is asked before the rest. Both frameworks pick their root through the same check, so where a root has to exist is stated once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On .NET Framework the path to the bundled viewer is carried as assembly metadata,
and every assembly built against the package carries one - prebuilt dependencies
included, where it is the package path of the machine that built them. The scan
took the first non-empty value it met and stopped, so a Verify.dll from NuGet
arriving before the test assembly handed back a directory that does not exist here,
the RID probe missed, and inline snapshots fell back to staging with a viewer
sitting in the package all along.
A value naming a directory that is not here is now passed over and the scan
continues, and the entry assembly - the one the targets stamped for this build - is
asked before the rest.
Both frameworks pick their root through the same check, so where a root has to
exist is stated once.