Read Disabled when it is asked for rather than at type initialisation - #825
Merged
Conversation
DiffRunner.Disabled captured DisabledChecker.IsDisable() in its initialiser, so whichever of the detectors reported first won for the life of the process. Setting BuildServerDetector.Detected or AiCliDetector.Detected after anything had touched DiffRunner did nothing at all - and a test host sets them after it has loaded, which is the only moment it can. BuildServerDetector.Detected is an AsyncLocal override on top of that, and a per-context value could never have reached a static captured once anyway. It is computed on read now, and an explicit set still pins it: consumers that assign Disabled keep the value they assigned, and nothing is read from the environment after that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DiffRunner.Disabled captured DisabledChecker.IsDisable() in its initialiser, so
whichever of the detectors reported first won for the life of the process. Setting
BuildServerDetector.Detected or AiCliDetector.Detected after anything had touched
DiffRunner did nothing at all - and a test host sets them after it has loaded,
which is the only moment it can. BuildServerDetector.Detected is an AsyncLocal
override on top of that, and a per-context value could never have reached a static
captured once anyway.
It is computed on read now, and an explicit set still pins it: consumers that
assign Disabled keep the value they assigned, and nothing is read from the
environment after that.