Keep the whole NoWarn list, and each target framework once - #826
Merged
Conversation
Directory.Build.props declared NoWarn twice. The second declaration replaced the first rather than adding to it, so CS0649, NU1608 and NU1109 were suppressed nowhere - and with TreatWarningsAsErrors on, the next unassigned field would have failed the build rather than warned in it. One list now, with everything both had. DiffEngine.csproj also listed net9.0 and net10.0 in both of its TargetFrameworks lines. MSBuild collapses that, so it built the same set, but the file said something it did not mean. Neither shows up in a build, which is why the two rules are asserted in a test instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Directory.Build.props declared NoWarn twice. The second declaration replaced the
first rather than adding to it, so CS0649, NU1608 and NU1109 were suppressed
nowhere - and with TreatWarningsAsErrors on, the next unassigned field would have
failed the build rather than warned in it. One list now, with everything both had.
DiffEngine.csproj also listed net9.0 and net10.0 in both of its TargetFrameworks
lines. MSBuild collapses that, so it built the same set, but the file said
something it did not mean.
Neither shows up in a build, which is why the two rules are asserted in a test
instead.