Show the snapshot an F# entry is anchored on - #827
Merged
Conversation
QueueEntry.Expected decided "new snapshot" from OriginalExpression being null and never looked at OriginalValue, which is the anchor a producer sends when its language does not implement CallerArgumentExpression. F# does not, so every F# entry opened with an empty expected pane and every received line marked as added - while the applier was anchoring on that same value and the staged expected.txt was written from it. It is the snapshot the expression would have parsed to, not source text: the patcher compares it against what a literal parses to, and against NewContent for an already-applied patch. So it goes in the pane as it is, under the plain "expected" header, and only a patch with neither anchor still reads as a new snapshot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QueueEntry.Expected decided "new snapshot" from OriginalExpression being null and
never looked at OriginalValue, which is the anchor a producer sends when its
language does not implement CallerArgumentExpression. F# does not, so every F#
entry opened with an empty expected pane and every received line marked as added -
while the applier was anchoring on that same value and the staged expected.txt was
written from it.
It is the snapshot the expression would have parsed to, not source text: the
patcher compares it against what a literal parses to, and against NewContent for an
already-applied patch. So it goes in the pane as it is, under the plain "expected"
header, and only a patch with neither anchor still reads as a new snapshot.