Leave the reader where they were when something else is removed - #828
Open
SimonCropp wants to merge 1 commit into
Open
Leave the reader where they were when something else is removed#828SimonCropp wants to merge 1 commit into
SimonCropp wants to merge 1 commit into
Conversation
Remove held the selection as an index and zeroed the scroll, so any removal above the entry on screen silently changed what was on screen - to whatever that index now landed on, at the top of it. Most removals are of something else: a settle from a test that has started passing, "Accept all in <solution>" from a header, a sweep that skipped this entry and took the rest. The selection follows its key now, the way Sync and EnqueueInline already did, and keeps its scroll. Only an entry that is itself gone falls back to advancing by index, which is the one case where the reader has to be moved at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove held the selection as an index and zeroed the scroll, so any removal above
the entry on screen silently changed what was on screen - to whatever that index
now landed on, at the top of it. Most removals are of something else: a settle from
a test that has started passing, "Accept all in " from a header, a sweep
that skipped this entry and took the rest.
The selection follows its key now, the way Sync and EnqueueInline already did, and
keeps its scroll. Only an entry that is itself gone falls back to advancing by
index, which is the one case where the reader has to be moved at all.