Do not step over the change block just above the viewport - #829
Merged
Conversation
PreviousChange started one row above the viewport and then stepped off any block it found there. That row is not in the viewport, so a block ending on it is one the reader has not been taken to - and it was skipped for the block before it. From row 17 with a change at 16, previous went to 2. From row 3 with a change at 2 it went nowhere at all, there being nothing before it to fall through to, so the first block in a file could not be reached from the row below it. It starts at the top row of the viewport now, the row NextChange starts at, and steps off a block only when that row is itself a change - which is the case stepping off was for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PreviousChange started one row above the viewport and then stepped off any block it
found there. That row is not in the viewport, so a block ending on it is one the
reader has not been taken to - and it was skipped for the block before it. From row
17 with a change at 16, previous went to 2. From row 3 with a change at 2 it went
nowhere at all, there being nothing before it to fall through to, so the first
block in a file could not be reached from the row below it.
It starts at the top row of the viewport now, the row NextChange starts at, and
steps off a block only when that row is itself a change - which is the case
stepping off was for.