Do not throw the reader to the top for selecting what is already selected - #830
Merged
Conversation
…cted Select reset the scroll unconditionally. A right click on the highlighted entry goes through it - OpenMenu selects the row first, so the menu acts on what is highlighted - so opening that menu, to reveal the source file say, jumped the comparison back to line 1 before the menu appeared. A left click on the highlighted row and a socket focus naming the entry already on screen did the same. Selecting the entry already selected now leaves the scroll alone. A different entry is a different comparison and still starts at its top.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Select reset the scroll unconditionally. A right click on the highlighted entry
goes through it - OpenMenu selects the row first, so the menu acts on what is
highlighted - so opening that menu, to reveal the source file say, jumped the
comparison back to line 1 before the menu appeared. A left click on the highlighted
row and a socket focus naming the entry already on screen did the same.
Selecting the entry already selected now leaves the scroll alone. A different entry
is a different comparison and still starts at its top.