Keep the scroll when a re-sent patch says what the last one said - #831
Open
SimonCropp wants to merge 1 commit into
Open
Keep the scroll when a re-sent patch says what the last one said#831SimonCropp wants to merge 1 commit into
SimonCropp wants to merge 1 commit into
Conversation
EnqueueInline started the reader at the top for any arrival carrying the key of the entry on screen, whether or not that entry changed. A continuous test runner sends one every few seconds for as long as the test keeps failing, so reading anything past the first screenful meant being thrown back to the top of it on every run. InlineQueue.Fold already reports an identical patch as unchanged and Project hands back the same entry, so the entry instance is the thing to compare. The attached path has always worked this way - SyncKeepsTheScrollWhenNothingChanged pins it - and this is the same rule on the path that owns the queue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EnqueueInline started the reader at the top for any arrival carrying the key of the
entry on screen, whether or not that entry changed. A continuous test runner sends
one every few seconds for as long as the test keeps failing, so reading anything
past the first screenful meant being thrown back to the top of it on every run.
InlineQueue.Fold already reports an identical patch as unchanged and Project hands
back the same entry, so the entry instance is the thing to compare. The attached
path has always worked this way - SyncKeepsTheScrollWhenNothingChanged pins it -
and this is the same rule on the path that owns the queue.