Clear the queue tooltip when it is forgotten - #832
Open
SimonCropp wants to merge 1 commit into
Open
Conversation
Forget reset the row and left the caption registered. Every caller of it - the cursor leaving the canvas, and a redraw, which renumbers the rows under a cursor that has not moved - is followed by the cursor being somewhere that has no tip, which arrives as row -1. That is the row Forget just set, so Apply returned with nothing to do and the last hovered row's text stayed registered on the whole canvas: resting anywhere brought it back, over the diff panes. Which is the bug this type was written to prevent, reached from the other side. Forget clears the text as well now, and takes the control it is clearing it on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forget reset the row and left the caption registered. Every caller of it - the
cursor leaving the canvas, and a redraw, which renumbers the rows under a cursor
that has not moved - is followed by the cursor being somewhere that has no tip,
which arrives as row -1. That is the row Forget just set, so Apply returned with
nothing to do and the last hovered row's text stayed registered on the whole
canvas: resting anywhere brought it back, over the diff panes. Which is the bug
this type was written to prevent, reached from the other side.
Forget clears the text as well now, and takes the control it is clearing it on.