vmui: expandable rows in Table view - #1644
Open
qveensi wants to merge 2 commits into
Open
Conversation
func25
added
the
web-ui
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Author
|
View extend log in table format |
Author
|
Thanks for the review — all three points addressed in 0625bc7:
|
Adds an optional renderExpandedRow prop to the generic Table component; when present, each row gets a chevron cell that toggles a full-width row with the prop's content. The logs Table view uses it to render the same field list as the Group view expansion (GroupLogsFields), so a single entry can be inspected without switching views. Other Table consumers are unaffected. VictoriaMetrics#1630
- reset expanded state on pagination bounds change, not tuple identity - add aria-expanded and a dynamic Expand/Collapse row label
qveensi
force-pushed
the
vmui-table-row-expand
branch
from
July 29, 2026 08:08
0625bc7 to
c599087
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #1630.
Tablegains an optionalrenderExpandedRow(row)prop — without it, rendered output is unchanged for other consumers (verified byte-identical in tests).GroupLogsFields— the exact field list / copy UI known from the Group view expansion.Unit tests added (
Table.test.tsx). Screenshots: attached in the comments below.Closes #1630