app/vmui: add per-instance favicon color customization - #1646
Open
Loori-R wants to merge 1 commit into
Open
Conversation
Loori-R
added
the
web-ui
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 23 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="app/vmui/packages/vmui/src/components/Configurators/GlobalSettings/GlobalSettings.tsx">
<violation number="1" location="app/vmui/packages/vmui/src/components/Configurators/GlobalSettings/GlobalSettings.tsx:52">
P3: Opening Settings can briefly reset a customized favicon to the default because this component starts a second `useBrowserTabSync` instance; it also duplicates the storage listener while the modal is open. Reusing the layout-level sync state/handler (for example, passing them into the palette) would keep synchronization single-owner and avoid the reset flash.</violation>
</file>
<file name="app/vmui/packages/vmui/src/utils/favicon.tsx">
<violation number="1" location="app/vmui/packages/vmui/src/utils/favicon.tsx:23">
P2: The mask icon never receives the selected color because the document link has `rel="mask-icon"` but no `id="mask-icon"`; only the `#favicon` link is updated. Selecting a color therefore leaves the existing mask icon at its initial `#000000` color, so selecting by its `rel` attribute (or adding the matching id) would keep all configured icon variants synchronized.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Loori-R
force-pushed
the
vmui/issue-1634/customize-favicon-color
branch
from
July 29, 2026 14:28
d03cd8c to
7460b6f
Compare
hagen1778
approved these changes
Jul 30, 2026
Contributor
|
@Loori-R I'd appreciate mirroring this change to VM repo as well. |
Loori-R
force-pushed
the
vmui/issue-1634/customize-favicon-color
branch
from
July 30, 2026 08:56
7460b6f to
ef20c8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Make VictoriaLogs instances easier to distinguish by allowing users to customize the favicon color. This PR also refreshes the Settings modal layout and controls.
Related issue: #1634
Changes
localStorageand synchronize it across browser tabsApplyandCancelbuttonsBrowser compatibility
Safari keeps the default favicon because it doesn't support data URL favicons.
Screenshots