Skip to content

helm-converter: fixed datasource auth, rules, remoteRead and remoteWrite params - #2431

Merged
vrutkovs merged 2 commits into
masterfrom
fixed-vmalert-conversion
Jul 28, 2026
Merged

helm-converter: fixed datasource auth, rules, remoteRead and remoteWrite params#2431
vrutkovs merged 2 commits into
masterfrom
fixed-vmalert-conversion

Conversation

@AndrewChubatiuk

Copy link
Copy Markdown
Contributor

addressed issues at #2398 (comment)

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread internal/converter/converter.go Outdated
Comment thread internal/converter/converter.go Outdated
Comment thread internal/converter/converter.go Outdated
@AndrewChubatiuk
AndrewChubatiuk force-pushed the fixed-vmalert-conversion branch from 6adc923 to f827cfd Compare July 22, 2026 15:54
@vrutkovs
vrutkovs enabled auto-merge (squash) July 28, 2026 10:42
@vrutkovs
vrutkovs merged commit 8560c3e into master Jul 28, 2026
9 checks passed
@vrutkovs
vrutkovs deleted the fixed-vmalert-conversion branch July 28, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants