Skip to content

operator: added Ignored status for child objects, do not mark object as failed if it was applied on at least one parent - #2438

Open
AndrewChubatiuk wants to merge 1 commit into
masterfrom
status-aggregation-fix
Open

operator: added Ignored status for child objects, do not mark object as failed if it was applied on at least one parent#2438
AndrewChubatiuk wants to merge 1 commit into
masterfrom
status-aggregation-fix

Conversation

@AndrewChubatiuk

Copy link
Copy Markdown
Contributor

fixes #2432

  • added Ignored status in child object was not picked by any parent
  • do not fail child if it was applied on at least one parent

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 12 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread internal/controller/operator/factory/k8stools/child_selection_cache.go Outdated
Comment thread internal/controller/operator/factory/k8stools/child_selection_cache.go Outdated
Comment thread internal/controller/operator/factory/reconcile/status.go Outdated
@AndrewChubatiuk
AndrewChubatiuk force-pushed the status-aggregation-fix branch from 4a424ce to e02ad4c Compare July 23, 2026 09:18
@AndrewChubatiuk

Copy link
Copy Markdown
Contributor Author

@cubic-ai-dev recheck

@cubic-dev-ai

cubic-dev-ai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

@cubic-ai-dev recheck

@AndrewChubatiuk I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 10 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread internal/controller/operator/factory/reconcile/status.go Outdated
Comment thread internal/controller/operator/factory/reconcile/status.go Outdated
@AndrewChubatiuk
AndrewChubatiuk force-pushed the status-aggregation-fix branch 2 times, most recently from 370359b to 40e6990 Compare July 23, 2026 15:39
…as failed if it was applied on at least one parent
@AndrewChubatiuk
AndrewChubatiuk force-pushed the status-aggregation-fix branch from 40e6990 to 368b06d Compare July 27, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VMRule status not updated when no longer in ruleSelector

2 participants